refactor/merge and fix tests#2697
Merged
simonredfern merged 14 commits intoOpenBankProject:developfrom Feb 16, 2026
Merged
Conversation
reset their password). One endpoint requires auth and role, the other is anonymous.
parentCustomerId: Option[String] to OutBoundUpdateCustomerGeneralData
parentCustomerId=Some(parentCustomerIdExample.value)) to connectors, Adding Dynamic Entity Test for _links
# Conflicts: # obp-api/src/test/scala/code/api/v6_0_0/PasswordResetTest.scala
- Add RetailAndCorporateCustomerTest suite with 482 lines of test coverage - Implement test cases for creating retail customers with validation of customer_type as INDIVIDUAL - Implement test cases for creating corporate customers with optional customer_type and parent_customer_id - Add helper methods createTestRetailCustomer and createTestCorporateCustomer for test setup - Add authentication and authorization tests verifying 401/403 responses for missing credentials and roles - Add test scenarios for retrieving retail and corporate customers at one bank - Add test scenarios for customer hierarchy operations (getCustomerChildren, getCorporateCustomerSubsidiaries) - Add test tags for API version v6_0_0 and individual endpoint tracking - Include cleanup in afterAll to bulk delete test customers and user-customer links - Covers CanCreateCustomer, CanCreateCustomerAtAnyBank, and CanGetCustomersAtOneBank entitlements
- Update frozen metadata cache for RestConnector_vMar2019 - Refresh test fixtures to reflect current API state - Ensure connector tests use latest metadata snapshot
- Update invokeDynamicConnector calls to pass userId only for personal entities - Pass None for userId when creating/updating/deleting system-level records - Pass Some(u.userId) for personal entity operations to maintain user context - Remove userId filter from system-level entity queries in MappedDynamicDataProvider - Add clarifying comments explaining userId handling for personal vs system entities - Ensures proper data isolation between personal and system-level dynamic entities
- Remove conditional userId logic that passed None for non-personal entities - Pass Some(u.userId) consistently across all invokeDynamicConnector calls - Update filtering strategy to rely on isPersonalEntity flag instead of userId presence - Simplify userId parameter handling in GET, POST, and PUT operations - Update comments to reflect new approach where personal records are filtered by userId at the connector level
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.